Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace minimp3 with dr_mp3 #96547

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

DeeJayLSP
Copy link
Contributor

@DeeJayLSP DeeJayLSP commented Sep 4, 2024

Note: waiting for dr_mp3 to add LAME tags + start delay support, to fix a bug that doesn't happen with minimp3.

Last time minimp3 got updated was in November 2021 (almost 3 years ago).

Meanwhile, dr_mp3, a piece of work done on top of minimp3, has been updated less than a year ago.

Within Godot, the main differences are:

  • No need for patches
  • No more MSVC warnings (removed system header treatment)
  • Possibility of overriding memory allocations (using memalloc)

Template release binary sizes remain the same.

Since minimp3 is removed, the following are also changed in this PR:

  • minimp3 module renamed to mp3
  • minimp3_extra_formats build variable renamed to mp3_extra_formats

This should not break compatibility unless module/build option name changes count (does not affect existing projects™).

@DeeJayLSP
Copy link
Contributor Author

Fixed an issue that caused single channel MP3 files to play badly.

This fix could also be applied to #80160 if it was viable

@DeeJayLSP
Copy link
Contributor Author

DeeJayLSP commented Sep 5, 2024

It seems like the change adds a 0.05-0.07s silence at the beginning on playback, gonna check if there's a way to fix this.

Edit: this seems like an issue of dr_mp3 itself. See mackron/dr_libs#263 for more info.
Until fixed and this PR gets updated, this should not be merged.

@DeeJayLSP DeeJayLSP marked this pull request as draft September 7, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants