Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: waiting for
dr_mp3
to add LAME tags + start delay support, to fix a bug that doesn't happen withminimp3
.Last time
minimp3
got updated was in November 2021 (almost 3 years ago).Meanwhile,
dr_mp3
, a piece of work done on top ofminimp3
, has been updated less than a year ago.Within Godot, the main differences are:
memalloc
)Template release binary sizes remain the same.
Since
minimp3
is removed, the following are also changed in this PR:minimp3
module renamed tomp3
minimp3_extra_formats
build variable renamed tomp3_extra_formats
This should not break compatibility unless module/build option name changes count (does not affect existing projects™).