Generate thumbnails on imported scenes. #96544
Draft
+184
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaracenOne
force-pushed
the
import_thumbnails
branch
from
d934af5
to
7da9533
Compare
|
In editor_inteface.cpp error in the comment on line 300 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ends a somewhat long-standing discontinuity of the imported scenes (FBX, GLTF, Collada, ect.) not having any thumbnail previews like regular Godot scenes. It does this by providing a hook step where they can be generated and cached upon reimport.
Keeping this in draft for now since it could probably benefit from further refactoring, improving bounds calculations for skinned meshes, and adding displayable gizmos for the cases where no mesh instances could be found (animation or collision-only imports, for example).