Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to copy a file's name in the FileSystem dock #96536

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YeldhamDev
Copy link
Member

image

Sponsored By: 🐺 Lone Wolf Technology / 🍀 W4 Games.

@YeldhamDev YeldhamDev added this to the 4.x milestone Sep 3, 2024
@YeldhamDev YeldhamDev requested a review from a team as a code owner September 3, 2024 17:06
@fire fire requested a review from a team September 3, 2024 17:42
@fire fire requested a review from a team September 3, 2024 17:43
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested but code looks good

@KoBeWi
Copy link
Member

KoBeWi commented Sep 3, 2024

Looks like niche option. You can copy path and delete everything besides the name (it takes 1-2 seconds). IMO it's not frequent enough operation to warrant bloating the menu. Most of the time you need the whole path.

@fire
Copy link
Member

fire commented Sep 3, 2024

I agree that bloating the menu is probably not worth the tradeoff. Maybe @YeldhamDev can make a convincing case to add this.

@timothyqiu
Copy link
Member

Maybe "Copy Filename"?

Copy Name brings me the question of whether it copies icon or icon.png.

@Flynsarmy
Copy link
Contributor

With this context menu getting longer (and it'll probably get longer again in the future when we introduce refactoring features) it might be best to put all the copy string functions into a sub menu.

That is if we even think this feature should be in core. It seems pretty niche and you can already hit F2 and copy which is just as fast.

@KoBeWi
Copy link
Member

KoBeWi commented Sep 4, 2024

btw we have new EditorContextMenuPlugin that allows implementing this feature with an addon.

@Arnklit
Copy link
Contributor

Arnklit commented Sep 4, 2024

Would resolve godotengine/godot-proposals#10173
Note: I suggested in that Proposal that you toggle the option with Alt similar to how MacOS does it in some right click menus, this would allow it to not bloat the menu length, but I don't know if this is a UI pattern we want to adopt in Godot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants