Fix loading GDExtensions in exported games #96287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulsntos
approved these changes
Aug 29, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue introduced by PR #91166
In current
master, GDExtensions will fail to load in exported projects. I noticed it first on Android, because you need to export in order to run on Android, but I've tested that this is the case for a desktop Linux export as well.Basically, we're getting the absolute path a little earlier than we should, which works when running the unexported project from the editor, but doesn't when the
.gdextensionfile is in the PCK file - we need to still use theres://path for loading that.This PR fixes the issue in my testing on both Linux and Android!