Improve some cryptic error messages in Node
#95063
Open
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
commented
Aug 2, 2024
| @@ -1685,13 +1685,13 @@ Node *Node::get_child(int p_index, bool p_include_internal) const { | |||
| if (p_index < 0) { | |||
| p_index += data.children_cache.size(); | |||
| } | |||
| ERR_FAIL_INDEX_V(p_index, (int)data.children_cache.size(), nullptr); | |||
| ERR_FAIL_INDEX_V_MSG(p_index, (int)data.children_cache.size(), nullptr, vformat("Invalid child index: %d.", p_index)); | |||
There was a problem hiding this comment.
Taken slightly modified from move_child, both could be improved but unsure what to add further
There was a problem hiding this comment.
Perhaps Failed to get_child() at index %d. The node (preferably a nodename if available), only has [data.children_cache.size()] children.
Arecher
reviewed
Aug 2, 2024
| @@ -2092,7 +2092,7 @@ void Node::set_owner(Node *p_owner) { | |||
| _clean_up_owner(); | |||
| } | |||
|
|
|||
| ERR_FAIL_COND(p_owner == this); | |||
| ERR_FAIL_COND_MSG(p_owner == this, "Invalid owner. Owner cannot be self."); | |||
There was a problem hiding this comment.
I'd suggest Attempted to set invalid owner (to [NodeName] if available). Owner cannot be self.
The difference is very slight, but I think using attempt indicates that although you tried, it didn't actually change the owner.
There was a problem hiding this comment.
This matches the error blow, so leaving it for consistency
AThousandShips
force-pushed
the
node_error_improve
branch
from
d0294e4 to
fe38795
Compare
ze2j
reviewed
Aug 3, 2024
AThousandShips
force-pushed
the
node_error_improve
branch
2 times, most recently
from
8d5a569 to
77d0709
Compare
AThousandShips
force-pushed
the
node_error_improve
branch
from
77d0709 to
673dc3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will look for more potential cases but these are some that stuck out or were mentioned
See: