Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #87462 "Fix PopupMenu doesn't respect its ScrollContainer's margins" #93297

Closed
wants to merge 1 commit into from

Conversation

@radiantgurl radiantgurl requested review from a team as code owners June 18, 2024 10:09
@radiantgurl
Copy link
Contributor Author

The ideal solution to be is not to revert the PR that attempts to fix a bug and introduces another one, but to have both of them fixed instead.

@akien-mga akien-mga requested review from a team and removed request for a team June 18, 2024 11:06
@radiantgurl
Copy link
Contributor Author

I swear to god Windows.....
It failed to download the D3D12 SDK with an HTTP error 503..

@akien-mga
Copy link
Member

So, I've been waiting to see if more investigation could be done on #93265 to understand the nature of the issue.

Reverting this visual change seems to only be addressing a symptom of the bug by changing slightly a position so that the bug isn't triggered. I'm not too keen on making such a change without understanding the root cause of the issue, as it means that issue may happen in other areas of the editor, or in user projects.

So far neither @bruvzg nor I managed to reproduce the issue on Linux, so it seems to affect only a subset of users. We'd need to identify which.

So I'd prefer not to merge this and instead go back to further debugging on #93265. It's probably too late to find a fix for 4.3-stable, but this is something we should hopefully be able to solve quickly after and backport to 4.3.1.

@akien-mga akien-mga closed this Jul 31, 2024
@akien-mga akien-mga removed this from the 4.3 milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Right clicking in the editor to open properties of a certain element instantly selects what's under cursor.
3 participants