Implement ClassDB::class_get_static_method

[RadiantUwU]

No description provided.

[Bromeon]

This is a great addition, thanks a lot 👍

The CI is currently encountering an error in the godot-cpp builds. I'm not sure if it's a codegen issue, but it looks like the keyword class is used in expression position, which should probably be escaped/renamed (likely unrelated to this PR)?

In file included from /home/runner/work/godot/godot/godot-cpp/include/godot_cpp/core/class_db.hpp:41,
                 from /home/runner/work/godot/godot/godot-cpp/gen/include/godot_cpp/classes/ref_counted.hpp:39,
                 from /home/runner/work/godot/godot/godot-cpp/include/godot_cpp/classes/ref.hpp:37,
                 from /home/runner/work/godot/godot/godot-cpp/gen/include/godot_cpp/classes/input_event.hpp:36,
                 from /home/runner/work/godot/godot/godot-cpp/gen/include/godot_cpp/classes/input_event_from_window.hpp:36,
                 from /home/runner/work/godot/godot/godot-cpp/gen/include/godot_cpp/classes/input_event_with_modifiers.hpp:37,
                 from /home/runner/work/godot/godot/godot-cpp/gen/include/godot_cpp/classes/input_event_mouse.hpp:37,
                 from /home/runner/work/godot/godot/godot-cpp/gen/include/godot_cpp/classes/input_event_mouse_motion.hpp:36,
                 from /home/runner/work/godot/godot/godot-cpp/gen/src/classes/input_event_mouse_motion.cpp:33:
/home/runner/work/godot/godot/godot-cpp/gen/include/godot_cpp/classes/class_db_singleton.hpp: In member function 'godot::Variant godot::ClassDBSingleton::class_call_static_method(const godot::StringName&, const godot::StringName&, const Args& ...)':
/home/runner/work/godot/godot/godot-cpp/gen/include/godot_cpp/classes/class_db_singleton.hpp:71:66: error: expected primary-expression before '(' token
   71 |   std::array<Variant, 2 + sizeof...(Args)> variant_args { Variant(class), Variant(method), Variant(args)... };
      |                                                                  ^

Apart from that, what do you think about naming it class_call_static instead of class_call_static_method?
Simply because that's consistent with Object::call, which isn't named Object::call_method either.

[RadiantUwU]

This is a great addition, thanks a lot 👍

The CI is currently encountering an error in the godot-cpp builds. I'm not sure if it's a codegen issue, but it looks like the keyword class is used in expression position, which should probably be escaped/renamed (likely unrelated to this PR)?

In file included from /home/runner/work/godot/godot/godot-cpp/include/godot_cpp/core/class_db.hpp:41,
                 from /home/runner/work/godot/godot/godot-cpp/gen/include/godot_cpp/classes/ref_counted.hpp:39,
                 from /home/runner/work/godot/godot/godot-cpp/include/godot_cpp/classes/ref.hpp:37,
                 from /home/runner/work/godot/godot/godot-cpp/gen/include/godot_cpp/classes/input_event.hpp:36,
                 from /home/runner/work/godot/godot/godot-cpp/gen/include/godot_cpp/classes/input_event_from_window.hpp:36,
                 from /home/runner/work/godot/godot/godot-cpp/gen/include/godot_cpp/classes/input_event_with_modifiers.hpp:37,
                 from /home/runner/work/godot/godot/godot-cpp/gen/include/godot_cpp/classes/input_event_mouse.hpp:37,
                 from /home/runner/work/godot/godot/godot-cpp/gen/include/godot_cpp/classes/input_event_mouse_motion.hpp:36,
                 from /home/runner/work/godot/godot/godot-cpp/gen/src/classes/input_event_mouse_motion.cpp:33:
/home/runner/work/godot/godot/godot-cpp/gen/include/godot_cpp/classes/class_db_singleton.hpp: In member function 'godot::Variant godot::ClassDBSingleton::class_call_static_method(const godot::StringName&, const godot::StringName&, const Args& ...)':
/home/runner/work/godot/godot/godot-cpp/gen/include/godot_cpp/classes/class_db_singleton.hpp:71:66: error: expected primary-expression before '(' token
   71 |   std::array<Variant, 2 + sizeof...(Args)> variant_args { Variant(class), Variant(method), Variant(args)... };
      |                                                                  ^

Apart from that, what do you think about naming it class_call_static instead of class_call_static_method?
Simply because that's consistent with Object::call, which isn't named Object::call_method either.

Its currently being overhauled to return a static callable directly

[Bromeon]

Hey, do you plan to pursue this? 🙂

[RadiantUwU]

Hey, do you plan to pursue this? 🙂

I do, and its still sitting on my hard drive, untested.

[dsnopek]

I just posted godot-cpp PR godotengine/godot-cpp#1485, which should fix the CI issues here, after it's been merged and cherry-picked to the 4.2 branch.

[RadiantUwU]

I just posted godot-cpp PR godotengine/godot-cpp#1485, which should fix the CI issues here, after it's been merged and cherry-picked to the 4.2 branch.

Oh i already changed this to create a custom callable instead to provide more flexibility to the users.

[Bromeon]

This is a different feature though...
Having the possibility to directly call static functions, as an equivalent to Object::call(), is still valuable.

I would also implement that one first, as it's always possible to add a Callable abstraction on top. However, with only the Callable, one needs to go through extra steps (both ergonomics and performance wise) for static calls.

Maybe the two deserve separate pull requests, so they can be discussed independently?

[dsnopek]

This new approach is interesting!

However, it is no longer an analog to Object::call() and makes for a sort of mismatched API. If we go with the Callable approach, we could maybe balance it by adding an Object::get_method() that returns a Callable for non-static methods?

Maybe the two deserve separate pull requests, so they can be discussed independently?

I agree. Even though they are functionally equivalent, the exposed API is very different between the two approaches.

[RadiantUwU]

I'll definitely put both methods on this pull request then, had no idea many people wanted it like this.
Also, i'm getting errors from the zstd library just so randomly, even though i never changed it.

[Bromeon]

I'll definitely put both methods on this pull request then, had no idea many people wanted it like this.

As dsnopek and I mentioned, it's probably better to have two separate pull requests, first one for ClassDB::class_call_static and later one for Callable.

Then, the discussions can flow independently, people can argue pro/con for each approach, and it's possible to merge one without the other, or at different times.

[RadiantUwU]

#93141

[RadiantUwU]

I need help with ZStd "macro redefined" even though i never touched it?

[RadiantUwU]

Found the issue, looks like its an improper merge conflict resolution.