Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] [Core] Fix AABB.encloses failing on shared upper bound #87214

Merged
merged 1 commit into from
Jan 15, 2024
Merged

[3.x] [Core] Fix AABB.encloses failing on shared upper bound #87214

merged 1 commit into from
Jan 15, 2024

Conversation

AThousandShips
Copy link
Member

This differs from Rect2 and was fixed for those classes in the past

3.x version of:

@AThousandShips
[Core] Fix AABB.encloses failing on shared upper bound
9aa001f 
This differs from `Rect2` and was fixed for those classes in the past
@AThousandShips AThousandShips added this to the 3.6 milestone Jan 15, 2024
@AThousandShips AThousandShips requested a review from a team as a code owner January 15, 2024 12:39
@akien-mga akien-mga merged commit 59eb1b6 into godotengine:3.x Jan 15, 2024
13 checks passed
@akien-mga
Copy link
Member

Thanks!

@AThousandShips
Copy link
Member Author

Thank you!

@AThousandShips AThousandShips deleted the aabb_fix_3_x branch January 15, 2024 13:37
@akien-mga akien-mga changed the title [3.x] [Core] Fix AABB.encloses failing on shared upper bound [3.x] [Core] Fix AABB.encloses failing on shared upper bound Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:core
Projects
None yet
Milestone
3.6
Development

Successfully merging this pull request may close these issues.
2 participants
@AThousandShips @akien-mga