-
-
Notifications
You must be signed in to change notification settings - Fork 21.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cut / copy / paste / duplicate functions to animation tree editors #83518
base: master
Are you sure you want to change the base?
Add cut / copy / paste / duplicate functions to animation tree editors #83518
Conversation
Adds the above functions to the animation blend tree, state machine and 1D / 2D blend space editors. Also exposes the existing delete function in the context menu and implements duplicate via menu and keyboard shortcut (CTRL+D), and CTRL+Drag for copying animation nodes.
909ca08
to
b99ad56
Compare
When I cut with Ctrl+X shortcut in the blend tree editor, I can't paste. Duplicate in BlendSpace1D is confusing. The new point is created at the same position and when you try to drag it, the point behind is selected instead and lacks selection highlight. When you cut and paste a node in StateMachine, undo is incorrect. Undoing paste does not delete the node. |
Thanks for looking at it. I wasn't sure how to handle duplicate in the blend space editors. Do you think the current version should be removed? Do you have a suggestion on how to improve it? I'll look at the issues you found in the coming days. |
I think it's fine currently, what I reported looks like existing selection bug. Clicking a stack of points will select the one added earlier, but the later one is on top, which looks like the point can't be selected. Maybe you could improve that somehow, as it's more important when duplicating. |
Are we able to merge partial the cut / copy / paste functions support for 4.3? What is missing? |
The last problem I mentioned (preview not refreshing after adding node) needs to be resolved. |
I'll find some time over the (German) Christmas holidays. I wasn't in a hurry because this wasn't assigned to a milestone and I was busy with other things. |
Really hoping this gets resolved soon. AnimationTree state machines are unnecessarily difficult to work with currently because you have to manually rebuild every single node that you want to move inside a nest. I've already had to rebuild the same state machine over and over again in order to get the nested structure set up how I want. If not this, there needs to be some other way to move nodes inside sibling state machines instead of manually deleting them and recreating them every time they need to be moved around. |
4.3 is currently in release freeze, so new features can only be merged in 4.4 at the earliest. Also, this PR needs to be rebased to resolve merge conflicts. |
@astillich Could you look into rebasing this PR on If you aren't available to do this, let us know and we can mark this PR as salvageable. |
Add cut / copy / paste / duplicate functions to animation tree editors
Adds the above functions to the animation blend tree, state machine and 1D / 2D blend space editors. Also exposes the existing delete function in the context menu and implements duplicate via menu and keyboard shortcut (CTRL+D), and CTRL+Drag for copying animation nodes.
Fixes #80009
Fixes godotengine/godot-proposals#8146