Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bool varying's generated code will be modified with flat #83194

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Fix bool varying's generated code will be modified with flat #83194

merged 1 commit into from
Oct 13, 2023

Conversation

jsjtxietian
Copy link
Contributor

Fixes #83193

@jsjtxietian jsjtxietian marked this pull request as ready for review October 12, 2023 11:42
@jsjtxietian jsjtxietian requested a review from a team as a code owner October 12, 2023 11:42
@Chaosus Chaosus added this to the 4.2 milestone Oct 12, 2023
QbieShay
QbieShay approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@QbieShay QbieShay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@akien-mga akien-mga merged commit 111a91a into godotengine:master Oct 13, 2023
@jsjtxietian jsjtxietian deleted the fix-bool-varying-code-gen branch October 13, 2023 09:52
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QbieShay QbieShay QbieShay approved these changes

Assignees
No one assigned
Labels
bug topic:shaders
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Failing to create boolean varying in visual shader editor
4 participants
@jsjtxietian @akien-mga @QbieShay @Chaosus