Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix highlight rect in "Whole search" being slightly offset #83101

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Fix highlight rect in "Whole search" being slightly offset #83101

merged 1 commit into from
Oct 10, 2023

Conversation

joao-pedro-braz
Copy link
Contributor

This fixes #83009.

cc @Calinou

akien-mga
akien-mga reviewed Oct 10, 2023
View reviewed changes
editor/find_in_files.cpp Outdated Show resolved Hide resolved
@akien-mga
Copy link
Member

Please amend the commit message to be meaningful :)

@akien-mga akien-mga added this to the 4.2 milestone Oct 10, 2023
@joao-pedro-braz
Fix highlight in Search panel being offseted
7945ca9 
This commit fixes the match highlight in the Find In Files
result panel being slightly offseted.
@joao-pedro-braz joao-pedro-braz force-pushed the fix-find-in-files-selection-offset branch from 868bfdc to 7945ca9 Compare October 10, 2023 12:10
Calinou
Calinou approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally (rebased on top of master c5291a3), it works as expected.

image

200% editor scale:

image

@akien-mga akien-mga merged commit b36e6dc into godotengine:master Oct 10, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga changed the title Fix highlight rect in "Whole search" being slightly offseted Fix highlight rect in "Whole search" being slightly offset Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga left review comments

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
bug regression topic:editor
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Highlight rect in "Whole search" is slightly offseted since 4.2.dev1
3 participants
@joao-pedro-braz @akien-mga @Calinou