Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Disable 2D property to Viewport (reverted) #82969

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Oct 7, 2023

This is the 2D counterpart to the existing Disable 3D property. Its functionality is already internally implemented and used, but it wasn't exposed.

Testing project: test_disable_2d.zip

Preview

simplescreenrecorder-2023-10-07_17.04.07.mp4

This is the 2D counterpart to the existing Disable 3D property.
Its functionality is already internally implemented and used,
but it wasn't exposed.
@Calinou Calinou force-pushed the viewport-add-disable-2d branch from dbef1b6 to f6cc260 Compare October 7, 2023 15:19
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, functionality is already present and just being hooked in

@akien-mga akien-mga modified the milestones: 4.x, 4.2 Oct 9, 2023
@akien-mga akien-mga merged commit 8384efe into godotengine:master Oct 9, 2023
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the viewport-add-disable-2d branch October 9, 2023 20:03
@akien-mga akien-mga changed the title Add a Disable 2D property to Viewport Add a Disable 2D property to Viewport (reverted) Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not render 2D nodes when there is no 2D camera present
3 participants