Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the OpenXR Eye gaze interaction extension #82614

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Oct 1, 2023

Builds upon #77989 and adds a second commit to address the remaining issues:

  • Leverage feature tags on mobile xr platforms for the following reasons:
    • Check whether the extension should be enabled using the XR_EXT_eye_gaze_interaction feature. This allows to disable the extension for pico devices until the remaining issues has been resolved by the vendor
    • Check whether necessary permissions are granted on mobile platforms using the PERMISSION_XR_EXT_eye_gaze_interaction feature.
  • Expands the feature tag api to allow Android plugins the ability to declare whether they support a feature or not
  • Automatically prompt for the necessary permissions on app startup

For full compatibility, these changes require updates to the OpenXR loaders plugin done in GodotVR/godot_openxr_vendors#48.

@m4gr3d m4gr3d force-pushed the openxr_eye_gaze_interaction branch from 424d57f to 10a651f Compare October 1, 2023 05:53
@m4gr3d m4gr3d requested a review from a team October 1, 2023 19:10
Copy link
Contributor

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this on Quest and works beautifully. I do think we need to introduce the extra project settings but other than that this works great!

@BastiaanOlij
Copy link
Contributor

Btw @m4gr3d , feel free to merge your changes and mine into a single commit. You can add a Co-authored-by: Bastiaan Olij <mux213@gmail.com> into the commit message.

@m4gr3d m4gr3d force-pushed the openxr_eye_gaze_interaction branch 2 times, most recently from 44e6015 to 6e6b60f Compare October 2, 2023 20:48
@m4gr3d m4gr3d requested review from a team as code owners October 2, 2023 20:48
@m4gr3d m4gr3d force-pushed the openxr_eye_gaze_interaction branch from 6e6b60f to f75536d Compare October 2, 2023 20:56
Co-authored-by: Bastiaan Olij <mux213@gmail.com>
@m4gr3d m4gr3d force-pushed the openxr_eye_gaze_interaction branch from f75536d to 9e56e7a Compare October 2, 2023 21:02
@akien-mga akien-mga merged commit 3a5d524 into godotengine:master Oct 3, 2023
@akien-mga
Copy link
Member

Thanks!

@m4gr3d m4gr3d deleted the openxr_eye_gaze_interaction branch October 3, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants