GDExtension: Use Uninitialized*Ptr
for constructors/converters using placement new
#78419
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few methods in the GDExtension header construct their destination in-place, but the parameters are not declared using the
Uninitialized*
pointer types.See godot-cpp PR: godotengine/godot-cpp#1148
Below are the relevant sections where placement new is used.
TypePtr constructors:
godot/core/variant/variant_construct.h
Lines 45 to 54 in 116f783
VariantPtr <-> TypePtr conversions:
godot/core/variant/variant_internal.h
Lines 1535 to 1546 in 116f783