Directly expose WebRTCPeerConnection::create_data_channel()
to GDExtension
#78237
+6
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to godot-cpp bug godotengine/godot-cpp#652, rather than directly exposing
WebRTCPeerConnection::create_data_channel()
, an alternate version which returned anObject *
(instead ofRef<T>
) was exposed, with a customcreate_data_channel()
that called it.Since that bug is now fixed, we can remove the workaround, and directly expose it!
I think this breaks compatibility, but since we're thoroughly breaking GDExtension compatibility for Godot 4.1 anyway, this seems like a good time to change this. :-)