-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default preview tonemapper to ACES #78106
base: master
Are you sure you want to change the base?
Change default preview tonemapper to ACES #78106
Conversation
I would disagree, while ACES may be a standard, it may be bad for people that wants more flexibility by default as filmic can give a better control while ACES is more for realistic games or engines like UE, and most users don't do realistic things here. |
How so? From what I've seen, the options are the same in 4.x with only exposure and white point settings for both of them. |
I mean artisticamly, as ACES has more contrast values that are more oriented in realism. |
I'm not sure it's such a good idea to use a more resource intensive mode by default like this |
ACES is barely more resource intensive.. I think FXAA is significantly more expensive, and that'll be default if #63470 is merged, not to mention glow is 10 times more expensive and it is on by default if I remember correctly |
See #49736 which also changes the tonemapper. ACES is definitely more resource-intensive than other tonemappers, but not by much. That said, this can be an issue on slow integrated graphics or mobile, so I'm having second thoughts about using ACES by default. I think we should stick to Filmic but use a whitepoint of 6 (Filmic with a whitepoint of 1 doesn't make much sense). ACES also has a notorious issue where it tends to make dark areas even darker, which some people dislike. Filmic is more neutral about this in comparison. |
Or you can add ACES to the forward+ renderer only as it the most expensive renderer with sdfgi and it stuff. |
Just because you use Forward+ doesn't mean you have a fast GPU that can handle SDFGI. Not everyone will use SDFGI when using Forward+ either, even if their GPU is fast enough. It's not the only reason to use Forward+, far from it. |
This is just something based on my preferences, but another
excusereason is that ACES seems to be the new standard now, considering that it's more accurate than Filmic.