Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused SVG icons #77419

Merged
merged 1 commit into from
May 27, 2023
Merged

Remove unused SVG icons #77419

merged 1 commit into from
May 27, 2023

Conversation

MewPurPur
Copy link
Contributor

  • Navigation2D and Navigation3D don't seem to be a thing in Godot 4, and these icons don't appear to be used elsewhere.
  • KeyTrackXForm doesn't seem to be used anywhere either. It looks identical to KeyTrackPosition, which is is used.

@MewPurPur MewPurPur requested a review from a team as a code owner May 24, 2023 04:02
fire
fire reviewed May 24, 2023
View reviewed changes
Copy link
Member

@fire fire left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The key xform was from an older version of the animation key editing.

@smix8 Any ideas about Navigation? If you're fine please approve.

smix8
smix8 approved these changes May 26, 2023
View reviewed changes
Copy link
Contributor

@smix8 smix8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old Navigation and Navigation2D icons can leave.

@Chaosus Chaosus added this to the 4.1 milestone May 27, 2023
@YuriSizov
Copy link
Contributor

YuriSizov commented May 27, 2023 •
edited
Loading

  • KeyTrackXForm doesn't seem to be used anywhere either. It looks identical to KeyTrackPosition, which is is used.

(It's KeyXform, no "track".) It was replaced in #53689, which makes me think that calling the new ones KeyXSomething is a mistake, since X in the old name was for Xform == Transform. But oh well 😄

@YuriSizov YuriSizov merged commit 9a3221f into godotengine:master May 27, 2023
@YuriSizov
Copy link
Contributor

Thanks!

@MewPurPur MewPurPur deleted the remove-unused-svgs branch May 27, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire left review comments

@YuriSizov YuriSizov YuriSizov approved these changes

@smix8 smix8 smix8 approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
5 participants
@MewPurPur @YuriSizov @fire @smix8 @Chaosus