-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GDScript: Add @warning_ignore_start
and @warning_ignore_restore
annotations
#76020
Merged
Repiteo
merged 1 commit into
godotengine:master
from
dalexeev:gds-warning-ignore-regions
Dec 9, 2024
Merged
GDScript: Add @warning_ignore_start
and @warning_ignore_restore
annotations
#76020
Repiteo
merged 1 commit into
godotengine:master
from
dalexeev:gds-warning-ignore-regions
Dec 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dalexeev
commented
Apr 13, 2023
•
edited
Loading
edited
- Closes `@warning_ignore_start` and `@warning_ignore_restore` godot-proposals#5405.
- Closes Ignore warnings for multiple lines in GDScript godot-proposals#5906.
- Resolves Signals from signal bus are marked as "not used in the class" #93202.
- Also removes a controversial undocumented feature. Instead, you can wrap the function in the annotations.
dalexeev
commented
Apr 13, 2023
dalexeev
force-pushed
the
gds-warning-ignore-regions
branch
from
April 13, 2023 11:55
765073c
to
22f6f59
Compare
dalexeev
force-pushed
the
gds-warning-ignore-regions
branch
2 times, most recently
from
May 10, 2023 14:51
988faa9
to
934c9a5
Compare
adamscott
reviewed
May 10, 2023
adamscott
reviewed
May 10, 2023
modules/gdscript/tests/scripts/parser/features/warning_ignore_regions.gd
Outdated
Show resolved
Hide resolved
dalexeev
force-pushed
the
gds-warning-ignore-regions
branch
from
July 28, 2023 14:40
934c9a5
to
2a8ebe2
Compare
dalexeev
force-pushed
the
gds-warning-ignore-regions
branch
from
February 4, 2024 17:37
2a8ebe2
to
8970540
Compare
dalexeev
force-pushed
the
gds-warning-ignore-regions
branch
2 times, most recently
from
February 6, 2024 06:51
4726907
to
0a42596
Compare
dalexeev
force-pushed
the
gds-warning-ignore-regions
branch
from
March 13, 2024 18:13
0a42596
to
b431af6
Compare
Mickeon
reviewed
Mar 14, 2024
dalexeev
force-pushed
the
gds-warning-ignore-regions
branch
from
March 15, 2024 09:25
b431af6
to
2d1e227
Compare
dalexeev
force-pushed
the
gds-warning-ignore-regions
branch
from
December 6, 2024 08:02
2d1e227
to
5bbf022
Compare
akien-mga
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
AThousandShips
approved these changes
Dec 6, 2024
dalexeev
force-pushed
the
gds-warning-ignore-regions
branch
from
December 6, 2024 12:37
5bbf022
to
7d65d0a
Compare
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.