C#: Optimize GetProcessDeltaTime() and GetPhysicsProcessDeltaTime() #74078
Conversation
Now the methods return a cached value instead of going through an internal call. I also added matching properties to reduce verbosity.
| virtual void set_physics_process_delta_time(double p_time); | ||
| virtual void set_process_delta_time(double p_time); |
There was a problem hiding this comment.
I thought of using the process_frame and physics_frame signals, but our callback needs to have priority, as we want the delta time to be updated before the other callbacks are called.
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| [SuppressMessage("Performance", "CA1822:Mark members as static")] | ||
| public partial double GetPhysicsProcessDeltaTime() => CachedPhysicsProcessDeltaTime; | ||
|
|
||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| [SuppressMessage("Performance", "CA1822:Mark members as static")] | ||
| public partial double GetProcessDeltaTime() => CachedProcessDeltaTime; |
There was a problem hiding this comment.
Should we hide/deprecate these methods in favor of the properties?
| @@ -112,6 +113,7 @@ struct ManagedCallbacks { | |||
| FuncDelegateUtils_TrySerializeDelegateWithGCHandle DelegateUtils_TrySerializeDelegateWithGCHandle; | |||
| FuncDelegateUtils_TryDeserializeDelegateWithGCHandle DelegateUtils_TryDeserializeDelegateWithGCHandle; | |||
| FuncScriptManagerBridge_FrameCallback ScriptManagerBridge_FrameCallback; | |||
| FuncScriptManagerBridge_SetProcessDeltaTime ScriptManagerBridge_SetProcessDeltaTime; | |||
There was a problem hiding this comment.
Forgot to add CHECK_CALLBACK_NOT_NULL to gd_mono_cache.cpp?
|
@RedworkDE also mentioned in #74070 (review) that |
|
After discussing, the .NET team has decided to close this PR. Since C# is moving to GDExtension, the callbacks that are added here to |
Now the methods return a cached value instead of going through an internal call. I also added matching properties to reduce verbosity.