Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Android export quicker (especially on Windows) #7079

Merged
merged 1 commit into from
Nov 11, 2016

Conversation

RandomShaper
Copy link
Member

Remove (comment out, as some lines already are) a lot of debug output during the export process which adds noticeable time to the duration of the export process.

I say "especially on Windows," because I think on other platforms the console is not as slow and on them it won't make a difference. Less clutter, anyway.

printf("stirng block len: %i\n",string_block_len);
printf("stirng count: %i\n",string_count);
printf("flags: %x\n",string_flags);
//printf("stirng block len: %i\n",string_block_len);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I'm more for deleting instead of commenting out, unless there is a strong reason we might want to reuse those in the future.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akien-mga hm.. personally, I prefer to leave it as comment.
Because it helps sometimes when fixing problem for android.

@RandomShaper
Copy link
Member Author

RandomShaper commented Nov 9, 2016 via email

@akien-mga
Copy link
Member

What about a dedicated compiler define so that we get both a cleaner-looking code and a easy way of enabling it back?

Definitely. I thought I had opened an issue to suggest it a while ago but it seems I did not, feel free to do it :)

@akien-mga
Copy link
Member

We could have a DEBUG_PRINT defined alongside https://github.com/godotengine/godot/blob/master/core/error_macros.h#L201-L232, which could rely on the -d, -debug command line flag to output its string.

@akien-mga akien-mga merged commit 84822c3 into godotengine:master Nov 11, 2016
@RandomShaper RandomShaper deleted the quicker-android-export branch November 13, 2016 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants