Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setting a global shader variable in the project settings #69600

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Fix setting a global shader variable in the project settings #69600

merged 1 commit into from
Dec 5, 2022

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Dec 5, 2022 •
edited
Loading

@Chaosus Chaosus requested a review from a team as a code owner December 5, 2022 10:48
@Chaosus Chaosus added this to the 4.0 milestone Dec 5, 2022
@Chaosus Chaosus added the crash label Dec 5, 2022
@Chaosus Chaosus force-pushed the fix_global_shader_crash branch from ec82a9c to 09f3001 Compare December 5, 2022 11:05
@Chaosus Chaosus changed the title Fix editor crash when setting a global shader variable Fix setting a global shader variable in the project settings Dec 5, 2022
@akien-mga akien-mga merged commit fd51427 into godotengine:master Dec 5, 2022
@akien-mga
Copy link
Member

Thanks!

@Chaosus Chaosus deleted the fix_global_shader_crash branch December 5, 2022 17:11
@Chaosus Chaosus mentioned this pull request Jan 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug crash topic:editor topic:shaders
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Cannot edit shader global uniforms in the project settings Broken undo when changing shader globals
2 participants
@Chaosus @akien-mga