Implement an EGL driver #68944
Closed
Implement an EGL driver #68944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riteo
force-pushed
the
egl-manager-only
branch
2 times, most recently
from
04c8cfd to
4724ec0
Compare
Riteo
force-pushed
the
egl-manager-only
branch
2 times, most recently
from
7a05e74 to
66547c9
Compare
|
Marking as a draft until I'm sure that EGL loading works well enough. |
Riteo
force-pushed
the
egl-manager-only
branch
from
66547c9 to
7f2c6d2
Compare
|
Seems to work fine now after a brief testing. |
|
Seems to work fine now after a brief testing. |
Riteo
force-pushed
the
egl-manager-only
branch
2 times, most recently
from
905902e to
84d14a8
Compare
Riteo
force-pushed
the
egl-manager-only
branch
from
84d14a8 to
682f9f0
Compare
This is needed by Wayland and could potentially be used by other platforms too, such as Android. This driver has been written in a platform-agnostic way, requiring the implementing platform to create a platform-specific manager inheriting from the EGLManager class, implementing the `_get_platform_extension_*` methods. It also includes its own GLAD loader and some extra logic for loading it automatically.
This was referenced Aug 17, 2023
|
Is it will be merged when #57025 will be ready? |
|
@stalkerg well it's needed for the Wayland backend to work so in one way or another... yes. Note though that this code has been also merged into #72831 which will probably get merged way before the Wayland PR is ready (time is little and this stuff takes time to polish), so this one might be closed if that happens. |
|
Since #72831 got merged, maybe we can rebase and see if there's any diff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR isn't meant to be merged as-is, as no current code references it.
This is needed by Wayland and could potentially be used by other platforms too, such as Android.
This driver has been written in a platform-agnostic way, requiring the implementing platform to create a platform-specific manager inheriting from the EGLManager class, implementing the
_get_platform_extension_*methods.It also includes its GLAD loader, currently only checking the Wayland platform extension.