Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Vector2i when returning atlas size in Geometry2D::make_atlas #66097

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Use Vector2i when returning atlas size in Geometry2D::make_atlas #66097

merged 1 commit into from
Sep 19, 2022

Conversation

Zylann
Copy link
Contributor

@Zylann Zylann commented Sep 19, 2022

I also wanted to change the array of Vector2 points into a PackedVector2iArray, but that type wasn't added to Variant. Will have to keep converting the data from float to int in GDExtension.

@Zylann Zylann requested review from a team as code owners September 19, 2022 10:39
@Zylann Zylann mentioned this pull request Sep 19, 2022
Open
@akien-mga akien-mga added this to the 4.0 milestone Sep 19, 2022
@akien-mga akien-mga merged commit 2d01768 into godotengine:master Sep 19, 2022
@akien-mga
Copy link
Member

Thanks!

@Zylann Zylann mentioned this pull request Sep 22, 2022
Open
79 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
breaks compat enhancement topic:core topic:2d
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Zylann @akien-mga