Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method bind for Geometry2D.decompose_polygon_in_convex #66096

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

4d49
Copy link
Contributor

@4d49 4d49 commented Sep 19, 2022

This adds a small function wrapper for an already existing function.

Bugsquad edit:

@4d49 4d49 requested a review from a team as a code owner September 19, 2022 10:24
@akien-mga
Copy link
Member

You also need to update and write the documentation for the exposed method: https://docs.godotengine.org/en/latest/community/contributing/updating_the_class_reference.html

@akien-mga akien-mga added this to the 4.x milestone Sep 19, 2022
@4d49 4d49 requested a review from a team as a code owner September 19, 2022 11:21
@4d49 4d49 force-pushed the decompose-polygon-in-convex branch from f8f2df8 to fc000dd Compare September 19, 2022 11:30
@4d49 4d49 force-pushed the decompose-polygon-in-convex branch from fc000dd to 623e23c Compare September 21, 2022 05:40
@4d49
Copy link
Contributor Author

4d49 commented Sep 21, 2022

You also need to update and write the documentation for the exposed method: https://docs.godotengine.org/en/latest/community/contributing/updating_the_class_reference.html

Done.

@akien-mga akien-mga modified the milestones: 4.x, 4.0 Sep 21, 2022
@akien-mga akien-mga merged commit 85a46d3 into godotengine:master Sep 21, 2022
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@4d49 4d49 deleted the decompose-polygon-in-convex branch September 21, 2022 11:41
@4d49
Copy link
Contributor Author

4d49 commented Sep 21, 2022

Thanks! And congrats for your first merged Godot contribution

Thank you, glad to help the community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose Geometry2D::decompose_polygon_in_convex() to GDScript
2 participants