Rename Image's get_rect to get_region
#66017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mickeon
force-pushed
the
rename-image-copy-rect
branch
from
658d266 to
eb0ccea
Compare
Mickeon
force-pushed
the
rename-image-copy-rect
branch
from
eb0ccea to
782b90b
Compare
mhilbrunner
reviewed
Nov 1, 2022
|
Will do then, after a well-deserved shower! |
Mickeon
force-pushed
the
rename-image-copy-rect
branch
2 times, most recently
from
ce91a08 to
235b4de
Compare
Mickeon
changed the title
get_rect to get_cropped_imageget_rect to get_region
|
There we go! |
|
@Mickeon Docs need to be re-sorted because they're not alphabetical anymore of the change, otherwise looks good to me! |
Also renames its parameter to from "rect" to "region".
Mickeon
force-pushed
the
rename-image-copy-rect
branch
from
235b4de to
ebf86c9
Compare
|
Ooops. |
mhilbrunner
approved these changes
Nov 2, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes godotengine/godot-proposals#5421.
This PR renames Image's
get_rect()toget_region()because the former is very vague, in the grand scheme of things. You may have just barely been able to tell what it does by looking at it.Also renames its parameter to from "rect" to "region".
Do note that the reason this name was chosen over
copy_rect()was because I felt like it didn't quite solve the issue brought up on the proposal. This PR can easily be changed if approved and if there's a clear consensus.