Fix crash when executing SubViewport.set_size_2d_override_stretch
#65477
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65456
I did not find a way to reproduce the crash, but the cause of the crash is quite obvious according to the crash log.
sample_count
is aVkSampleCountFlagBits
enum, it's equal to the actual number of bits (1, 2, 4, 8, 16, ...).rasterization_sample_count
is an array to mapTextureSamples
toVkSampleCountFlagBits
.p_requested_sample_count
is aTextureSamples
enum, it can be used to indexrasterization_sample_count
.So using
sample_count
to indexrasterization_sample_count
will result in a crash when it's greater thanTEXTURE_SAMPLES_MAX
(7).sample_count
should be used directly like in the otherif
branch.