Rename ProgressBar.percent_visible to show_percentage
#65038
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mickeon
force-pushed
the
rename-progressbar-percent
branch
from
a759972 to
e08469e
Compare
akien-mga
approved these changes
Sep 6, 2022
akien-mga
reviewed
Sep 6, 2022
Mickeon
force-pushed
the
rename-progressbar-percent
branch
from
e08469e to
16b4ef1
Compare
`percent_visible` -> `show_percentage` `set_percent_visible` -> `set_show_percentage` `is_percent_visible` -> `is_percentage_shown`
Mickeon
force-pushed
the
rename-progressbar-percent
branch
from
16b4ef1 to
f0916a4
Compare
|
Thanks! Merged manually as 08c2aab (should have been auto-closed and shown as merged but I wrongly rebased locally after doing a local merge...). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Judging by this comment's confusion, #64665 (comment), a rename may be needed, even if it may not be this one #64665 (comment).
For ProgressBar:
percent_visible->show_percentageset_percent_visible->set_show_percentageis_percent_visible->is_percentage_shownNote that this is no longer truly "required", because Label and RichTextLabel's
percent_visible, an entirely different and unrelated property, had its name changed already in the aforementioned PR.