Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide MenuButton / OptionButton popup on click if it's already visible. #64768

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Hide MenuButton / OptionButton popup on click if it's already visible. #64768

merged 1 commit into from
Aug 26, 2022

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Aug 23, 2022 •
edited
Loading

Prevents popups from staying open and jumping around when rapid clicking on the Button control.

TODO:

  • Test with embedded windows.
  • Test on Windows.
  • Test on Linux/X11.
  • Test on macOS.

@bruvzg bruvzg added this to the 4.0 milestone Aug 23, 2022
@bruvzg bruvzg marked this pull request as ready for review August 24, 2022 07:45
@bruvzg bruvzg requested a review from a team as a code owner August 24, 2022 07:45
@akien-mga akien-mga merged commit ac7b511 into godotengine:master Aug 26, 2022
@akien-mga
Copy link
Member

Thanks!

@bruvzg bruvzg deleted the popups_hide_if_visible branch August 26, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:gui
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bruvzg @akien-mga