Rename and unify notation for spherical interpolation #63532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokageItLab
force-pushed
the
rename-cubic-slerp
branch
from
0c01867 to
4211e68
Compare
fire
approved these changes
Jul 27, 2022
reduz
approved these changes
Jul 28, 2022
|
Thanks! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cubic interpolation was implemented some correctly by #63380.
The name
cubic_slerp()has a contradictory meaning, "cubic spherical linear interpolation", so it is renamedspherical_cubic_interpolate()to correspond toslerp(). I felt thatscerp()is odd.Transform3D::sphere_interpolate_with()is also renamed toTransform3D::spherical_interpolate_with()to accommodate this.