Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added alert install libvulkan or vulkan apis [linux] #62285

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stupid-kid-af
Copy link

Installed opensuse tumbleweed and it was showing that vulkan not supported but it does. Then I installed libvulkan-intel, libvulkan-32 and the issue get fixed. So for anyone else getting these errors can read on the dialog and install the vulkan apis or drivers. In this PR I added one line about vulkan drivers in the alerts.

@stupid-kid-af
Copy link
Author

In some issues like this, the alert could be helpful

@Calinou
Copy link
Member

Calinou commented Jun 21, 2022

In some issues like this, the alert could be helpful

You've only added the message on Linux, but that issue was reported on Windows.

Also, if you don't have Vulkan DLLs installed on Windows, you'll currently get a different dialog on startup as Godot will not be able to start at all (similar to what's reported in pal1000/mesa-dist-win#63). Therefore, you'll never be able to see the message you added, even on Windows.

@stupid-kid-af
Copy link
Author

means that this would not be helpful in case of Windows so I've to do some work for Windows dialog
Also, I opened PR for only linux systems

@stupid-kid-af stupid-kid-af changed the title added alert install libvulkan or vulkan apis added alert install libvulkan or vulkan apis [linux] Jun 21, 2022
@akien-mga
Copy link
Member

There was a similar proposal in the past, but I still don't think that's a good idea. How to set up Vulkan drivers is not only OS but also distro specific so we can't start listing names of Mesa packages that may work for some distros but not others, and wouldn't work for users with a Nvidia GPU.

We can have troubleshooting documentation on how to set up Vulkan somewhere, but since this is not Godot specific, this is likely something that others have done already and not our prerogative. For example: https://linuxconfig.org/install-and-test-vulkan-on-linux

On the other hand we can maybe tweak the message for all OSes to clarify that Vulkan not being found can mean either no support or no drivers.

@stupid-kid-af
Copy link
Author

that's right but this happens while accessing vulkan apis but there are still some guys having these issues and they think that this is godot's issue/error

@Calinou
Copy link
Member

Calinou commented Jun 22, 2022

could anyone approve me

Please don't bump a pull request to run CI for a trivial string change like this – especially before we reach an agreement on the changes that should actually be made.

@stupid-kid-af
Copy link
Author

could anyone approve me

Please don't bump a pull request to run CI for a trivial string change like this – especially before we reach an agreement on the changes that should actually be made.

Sorry man, I accidentally made a comment here, I was making the comment on Docs

@YuriSizov YuriSizov modified the milestones: 4.0, 4.x Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants