Tweak default ProceduralSkyMaterial and PhysicalSkyMaterial appearance #57993
+35
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Tweak colors to be less saturated and more balanced (in terms of hue). The cool blue sky is balanced by a warm brown ground, which makes reflections look closer to how they'd look like when using an HDRI panorama texture. - Make the ground color dark on both ProceduralSkyMaterial and PhysicalSkyMaterial to reduce indoor light leaking, especially when using GI. - Tweak the PhysicalSkyMaterial colors to be as close as possible to ProceduralSkyMaterial (with the default sun orientation). - Tweak editor environment defaults to be identical to the default ProceduralSkyMaterial colors. Previously, the default editor sky color was different from the colors of a newly created ProceduralSkyMaterial resource. Both new skies were tested without GI, with SDFGI and with VoxelGI. They were tuned to look best when using ACES tonemapping with a whitepoint set to 6, but they still look good with other tonemapping operators.
Calinou
force-pushed
the
sky-tweak-default-values
branch
from
a4c110e to
b7b18a4
Compare
clayjohn
approved these changes
Feb 12, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both new skies were tested without GI, with SDFGI and with VoxelGI. They were tuned to look best when using ACES tonemapping with a whitepoint set to 6, but they still look good with other tonemapping operators.
This partially addresses godotengine/godot-proposals#348.
Testing project: environment_tweaks.zip
Preview
Screenshots
Glow is disabled, and tonemapper is set to ACES with a whitepoint of 6 (as done in #49736).
Simple scene (non-textured)
ProceduralSkyMaterial, No GI
ProceduralSkyMaterial, SDFGI
ProceduralSkyMaterial, VoxelGI
PhysicalSkyMaterial, No GI
PhysicalSkyMaterial, SDFGI
PhysicalSkyMaterial, VoxelGI
Octavus (non-textured)
ProceduralSkyMaterial, No GI
ProceduralSkyMaterial, SDFGI
PhysicalSkyMaterial, No GI
PhysicalSkyMaterial, SDFGI
Octavus (textured)
ProceduralSkyMaterial, No GI
ProceduralSkyMaterial, SDFGI
PhysicalSkyMaterial, No GI
PhysicalSkyMaterial, SDFGI