-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCons: Do not print a warning when passing profile
to command-line
#55698
Conversation
The `profile` option is used to specify default SCons options via file. However, this prints a warning when the option is used, because it's unrecognized by SCons. Adding `profile` as an actual SCons option is not a solution, because it's used as a base for `Variables()`. therefore ignoring this option when printing an warning is enough.
This could also be extended to Mono-specific SCons options, which are currently considered to be unknown. |
I looked into this, looks like the problem is that This is certainly outside the scope of this PR and requires some major refactor, due to this I think that #55203 should be reverted in 3.x branch, this affects my projects like: https://github.com/goostengine/goost, https://github.com/Xrayez/godot-anl etc. Hardcoding values into the list as in this PR would also be quite hacky and error-prone, I don't recommend it. Again, this is not only about built-in modules, #55203 affects custom modules as well. |
See #53030 which aimed to address that for Mono options while implementing the same feature. I agree that hardcoding "not yet known" parameters is not a good option as it doesn't scale well for custom modules. I'll revert the change for |
Thanks, note that I think this PR is still needed since But it's up to you. |
I noticed #56359 popped up, so yeah I recommend merging this PR. |
I prefer to revert the change for now as there are still regressions to solve beside the special case of |
This is an excellent decision. |
The
profile
option is used to specify default SCons options via file. However, after #55203, this prints a warning when the option is used, because it's unrecognized by SCons.Warning: Adding
profile
as an actual SCons option is not a solution, because it's used as a base forVariables()
. therefore ignoring this option when printing a warning is enough.For those not familiar with
profile
, see also #38821.Bugsquad edit: This closes #56359.