Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix array access in gdextensions #55039

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Fix array access in gdextensions #55039

merged 1 commit into from
Nov 17, 2021
+2 −2

Conversation

BastiaanOlij
Copy link
Contributor

Turns out C++ was taking the pointer to our self pointer and indexing that, instead of calling operator[], calling it explicitly fixes it.

This makes godotengine/godot-cpp#627 usable

@BastiaanOlij BastiaanOlij added this to the 4.0 milestone Nov 16, 2021
@BastiaanOlij BastiaanOlij requested a review from a team as a code owner November 16, 2021 23:38
@BastiaanOlij BastiaanOlij self-assigned this Nov 16, 2021
@akien-mga akien-mga merged commit 3c04522 into godotengine:master Nov 17, 2021
@akien-mga
Copy link
Member

Thanks!

@BastiaanOlij BastiaanOlij deleted the fix_gdnative_array_index branch November 17, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees

@BastiaanOlij BastiaanOlij

Labels
bug topic:gdextension
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@BastiaanOlij @akien-mga