[3.x] Remove do{ } while(0) wrapper around error macros #52591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothyqiu
force-pushed
the
error-macros
branch
from
3d4f821 to
e8c607b
Compare
timothyqiu
force-pushed
the
error-macros
branch
from
e8c607b to
70853fd
Compare
akien-mga
approved these changes
Sep 21, 2021
|
Thanks! |
Xrayez
added a commit
to goostengine/goost
that referenced
this pull request
Sep 21, 2021
Fixes build caused by godotengine/godot#52591...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is basically the
3.xversion of #36011, changingdo {} while (0)toif (cond) {} else ((void)0).The main motivation to backport the PR is to suppress static analyzer warnings about using integers instead of boolean literals (
while (0)instead ofwhile (false)).Main changes are in
core/error_macro.h. These changes expose missing semicolon errors when usingERR_*macros, so other files are touched to fix them.