Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Undo/Redo menu items #51775

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Improve Undo/Redo menu items #51775

merged 1 commit into from
Aug 17, 2021

Conversation

timothyqiu
Copy link
Member

  • Make Undo/Redo menu items disabled when clicking it does nothing.
    • Context menu of TextEdit
    • Context menu of LineEdit
    • Editor's Scene menu
    • Script editor's Edit menu and context menu
  • Make editor undo/redo log messages translatable.
  • Mark UndoRedo's has_{un,re}do() methods as const.
  • Expose TextEdit's has_{un,re}do() to scripts since {un,re}do() are already available.

@timothyqiu timothyqiu added this to the 4.0 milestone Aug 17, 2021
@timothyqiu timothyqiu requested review from a team as code owners August 17, 2021 03:49
@timothyqiu timothyqiu mentioned this pull request Aug 17, 2021
Merged
Paulb23
Paulb23 reviewed Aug 17, 2021
View reviewed changes
Copy link
Member

@Paulb23 Paulb23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to apply this to TextEditor as well.

@timothyqiu
Copy link
Member Author

Would be good to apply this to TextEditor as well.

Ah, I did the PR on 3.x first, so I didn't notice there's also a TextEditor on master. I'll add that :)

@timothyqiu
Improve Undo/Redo menu items
16c2d4e 
* Make Undo/Redo menu items disabled when clicking it does nothing.
    * Context menu of `TextEdit`
    * Context menu of `LineEdit`
    * Editor's Scene menu
    * Script editor's Edit menu and context menu (for Script and Text)
* Make editor undo/redo log messages translatable.
* Mark `UndoRedo`'s `has_{un,re}do()` methods as `const`.
* Expose `TextEdit`'s `has_{un,re}do()` to scripts since `{un,re}do()` are already available.
@timothyqiu timothyqiu requested a review from Paulb23 August 17, 2021 14:45
@akien-mga akien-mga merged commit 273d1ca into godotengine:master Aug 17, 2021
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the disable-undo-redo branch August 17, 2021 17:11
@timothyqiu timothyqiu mentioned this pull request Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Paulb23 Paulb23 Paulb23 approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor topic:gui usability
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@timothyqiu @akien-mga @Paulb23