API improvement on the physics (CharacterBody and related classes) #51645
+333
−198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pouleyKetchoupp
suggested changes
Aug 13, 2021
Changes: - Rename few methods/property and group them in the editor when it's possible - Make MotionResult API consistency with KinematicCollision - Return a boolean in move_and_slide if there was a collision - New methods: - get_floor_angle on CharacterBody to get the floor angle. - get_angle on KinematicCollision to get the collision angle. - get_last_slide_collision to quickly get the latest collision of move_and_slide.
fabriceci
force-pushed
the
improve-physics-api
branch
from
018c819 to
d776b6c
Compare
pouleyKetchoupp
approved these changes
Aug 16, 2021
akien-mga
changed the title
|
Thanks! |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes changes in the API according chat's discussions and aims to steer the API to his final form for 4.0 alpha.
Changes:
KinematicCollisionmove_and_slideif there was a collisionget_floor_angleonCharacterBodyto get the floor angle.get_angleonKinematicCollisionto get the collision angle.get_last_slide_collisionto quickly get the latest collision ofmove_and_slide.