Bake RESET animation.

[fire]

Co-Authored-by MMMaellon
Co-Authored-by Eron.

Corresponding pr to godotengine/godot-proposals#2961.

[akien-mga]

Co-Authored-by MMMaellon
Co-Authored-by Eron.

Note that if you want them properly credited as authors by GitHub, you have to use this exact syntax (and IIRC at the end of the commit message):

Co-authored-by: Name <email>

[fire]

Sample project for verification. https://drive.google.com/drive/folders/15TnICjTpcr3dGEAJwcuWb69B5Gy9HP4f from @AndreaCatania

[RandomShaper]

Code-wise I don't see any big issue and it looks as it does what it promises.

If anything, I'd add a comment with a bird view explanation of the algorithm, like a numered bullet list) in editor_importer_bake_reset.cpp, even including some URLs of the reference materials in the proposal. The goal is to make this somehow obscure piece of code not so intimidating for potential future maintainers.

[fire]

I have copy and pasted the proposal details into the source file.

[RandomShaper]

Cool, but now I'd say it's too unscoped. I'm sorry to annoy you with this, but it'd be better to include an explanation about what each step of the algorithm do (which may include references to the implementation it has been inspired in), instead of the rationale for adding the feature.

[fire]

@RandomShaper I added some comments at crucial parts of the algorithm, but it doesn't seem much.

[RandomShaper]

I think it does the trick quite well. 😀

[RandomShaper]

Looks good to me. My only doubt is about how much green light we can consider the proposal got. For my part, I understand this feature aligns very well with the Godot principle of parallel work among a team and the implementation is clean.

[akien-mga]

Thanks!

[akien-mga]

If the feature is wanted in 3.x too, this might need a dedicated backport, as the resource_importer_scene.cpp code changed significantly.

[fire]

I'll see what I can do.

Edited:

Thinking about the topic for a few minutes, I want to complete my todo list of items like 8 uvs for gltf2 (4.x) and gltf2 export bugfixes (for 3.x and 4.x) done.

[slapin]

Could this be backported to 3.x please?