Add get_buffered_amount() to WebRTCDataChannel #50658
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This methods gives access to
RTCDataChannel.bufferedAmount
- see:https://developer.mozilla.org/en-US/docs/Web/API/RTCDataChannel/bufferedAmount
This can be useful for checking if SCTP is buffering data (possibly due to its flow control kicking in) and then waiting to send more data until the buffer clears.
This comment on
DataChannelInterface::Send()
is a really good explanation of the motivation for this:https://github.com/maitrungduc1410/webrtc/blob/master/api/data_channel_interface.h#L191
This won't cleanly cherry-pick to 3.x and requires some minor changes, so I'll make a separate PR.
I'll also make a PR to the GDNative plugin, but I'm not sure how the GDNative part will work with backward compatibility? This changes the
godot_net_webrtc_data_channel
struct which will cause old version of the GDNative plugin to not work until updated, and also updated versions of the GDNative plugin won't work with older versions of Godot.