Redefine var results in an error #4918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error rised if redefine - function argument - for-loop argument - local-scope var Affects godotengine#3730
|
it makes sense that this would be an error, but it would probably break a lot of people's code to fix |
neikeq
changed the title
|
Maybe we could merge a version that raises a warning, and only make it a blocking error in 3.0? To let people know about the need to fix their code in 2.1 already. |
|
We're now working on Godot 3.0, this could be considered for merging again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error raised if redefine
Affects #3730
Well, there is still a dirty hack with
cf_for->body->variables.push_back(id->name);. It is the only simple way Ive found for protect for-loop var from being redefined.And I'm pretty sure I've missed something important =/