Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow values > 1 for friction and bounce in PhysicsMaterial #48434

Merged
merged 1 commit into from
May 4, 2021
Merged

Allow values > 1 for friction and bounce in PhysicsMaterial #48434

merged 1 commit into from
May 4, 2021

Conversation

pouleyKetchoupp
Copy link
Contributor

Allows friction and bounce in PhysicsMaterial to be set with values higher than 1 in the editor, but still doesn't allow negative values and clamps the slider between 0 and 1.

Fixes #48298
Supersedes #48321

@pouleyKetchoupp pouleyKetchoupp added bug topic:physics regression cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.3 labels May 4, 2021
@pouleyKetchoupp pouleyKetchoupp added this to the 4.0 milestone May 4, 2021
@pouleyKetchoupp pouleyKetchoupp requested a review from a team May 4, 2021 00:55
@pouleyKetchoupp pouleyKetchoupp mentioned this pull request May 4, 2021
Closed
@akien-mga
Copy link
Member

Seems good to solve the immediate issue, but I still think we should also improve the documentation as I mentioned here: #48321 (comment)

After all this discussion it's still unclear to me whether friction > 1 is physically correct or not. From the bug report it seems like friction may not be a ratio.

@akien-mga akien-mga mentioned this pull request May 4, 2021
Closed
@pouleyKetchoupp
Copy link
Contributor Author

Seems good to solve the immediate issue, but I still think we should also improve the documentation as I mentioned here: #48321 (comment)

After all this discussion it's still unclear to me whether friction > 1 is physically correct or not. From the bug report it seems like friction may not be a ratio.

Yeah, definitely. It will require some tests, because it's a bit different between Godot Physics and Bullet if I remember correctly.

@akien-mga akien-mga merged commit b5e4d63 into godotengine:master May 4, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.3.1.

@akien-mga
Copy link
Member

Cherry-picked for 3.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label May 4, 2021
@pouleyKetchoupp pouleyKetchoupp deleted the friction-bounce-greater-than-1 branch May 4, 2021 15:41
@pouleyKetchoupp pouleyKetchoupp mentioned this pull request May 4, 2021
Open
@pouleyKetchoupp
Copy link
Contributor Author

For info, I've opened #48461 to keep track of the documentation issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug regression topic:physics
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Friction in PhysicsMaterial is too low even at 1.0 (the max)
2 participants
@pouleyKetchoupp @akien-mga