Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mono] Use the same search logic for both MSBuild and dotnet. #45715

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Feb 4, 2021

Use the same FindBuildEngineOnUnix for both build tools.
Add paths for the homebrew and standalone installations of dotnet to the search list on macOS.

Fixes #38985

@bruvzg bruvzg added bug platform:macos topic:editor topic:dotnet cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Feb 4, 2021
@bruvzg bruvzg requested a review from neikeq as a code owner February 4, 2021 20:43
@akien-mga akien-mga merged commit a7a51fb into godotengine:master Feb 5, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.2.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Feb 5, 2021
@akien-mga akien-mga added this to the 4.0 milestone Feb 5, 2021
@bruvzg bruvzg deleted the mono_dotnet_path branch February 15, 2021 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.2.2beta3 Cannot find dotnet CLI executable. Fallback to MSBuild from Mono
2 participants