-
-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort editor help documentation methods and properties by alphabetical order #39141
Conversation
Can you take a before/after screenshot so we can see the difference? Reading the code, I'm not sure if grouping by first letter is actually an upgrade. |
I like the change, it makes it easier to quickly navigate visually. It's definitely an ergonomic change if nothing else. |
Looks good to me as well. |
Commits should be squashed into one: https://docs.godotengine.org/en/latest/community/contributing/pr_workflow.html#the-interactive-rebase |
Should I close de PR now? |
@ChristopheLY No, it will be closed automatically when it's merged. |
may fixe, #35347 |
@ChristopheLY Is this still desired? If so, it needs to be rebased and tested on the latest master branch. |
Discussed in PR review. Needs review by someone knowledgeable with docs formatting. Not urgent for 4.0 |
I'm not convinced either. The API is just too varied and grouping by the first letter is bound to introduce a lot of unnecessary splitting in some classes. We could probably do something smarter, and try to separate large groups of methods based on a prefix, while grouping smaller chunks together regardless of their name. It would be nice to fix the linked issue though. But this PR needs to be reworked against the current master. |
This shouldn't be relevant any longer as this was solved in past PRs like: Edit: Indeed the associated issue was closed as solved, so closing this Thank you for your contribution nonetheless! |
Closes #35347.