DisplayServer: Some fixes to X11, build system and Window class #37029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuruk-mm
changed the title
kuruk-mm
force-pushed
the
display-server
branch
3 times, most recently
from
f52f524 to
ca7e709
Compare
kuruk-mm
force-pushed
the
display-server
branch
from
ca7e709 to
6d6dd8e
Compare
reduz
requested changes
Mar 14, 2020
reduz
requested changes
Mar 14, 2020
reduz
requested changes
Mar 14, 2020
reduz
requested changes
Mar 14, 2020
|
I make a new commit to make easier to review Done, please before merge, let me know, because I want to squash the commits to have a clean git history |
kuruk-mm
force-pushed
the
display-server
branch
2 times, most recently
from
fdc57d3 to
7b5e978
Compare
|
Ready to merge as you requested on IRC @reduz Know bug:
Please take care from this: If you delete a window and an event was pending, MainWindow will receive it instead of the deleted window. Anyway I think this can be Ok because is Thread Safe, so I just remark to have a knowledge |
kuruk-mm
changed the title
kuruk-mm
force-pushed
the
display-server
branch
2 times, most recently
from
d55f5e8 to
4393360
Compare
akien-mga
reviewed
Mar 16, 2020
| @@ -63,68 +63,5 @@ def make_app_icon(target, source, env): | |||
| g.write("};\n") | |||
| g.write("#endif") | |||
|
|
|||
|
|
|||
| def make_default_controller_mappings(target, source, env): | |||
There was a problem hiding this comment.
For the reference if anyone wonders about this removal: this code was moved to core/input/.
akien-mga
reviewed
Mar 16, 2020
Travis: Change x11 to linuxbsd scons: Change x11 plataform to linuxbsd scons: Delete make_default_controller_mappings from main_builder Plugins: Remove ; to avoid fallthrough warning DisplayServer: Fix some Window class issues and x11 resize to rect_changed DisplayServerX11: Implement set_icon DisplayServerX11: Fix X11 bug when a window was erased from windows map, all the changes from that erased windows are sending to the main window DisplayServerX11: Reorder create_window commands, and add flags parameter DisplayServerX11: Change every Size2 to Size2i and Rect2 to Rect2i where it belongs DisplayServerX11: Implement screen_get_usable_rect
kuruk-mm
force-pushed
the
display-server
branch
from
4393360 to
a09f0e5
Compare
|
Updated from @reduz last changes Popups are working fine
|
This was referenced Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes and Fix #37002
CI repaired (Mac is failing, I'm not going to fix that)
X11 now is compiling, working
(but with love), and no crashing your entire desktop guiKnown bugs:
Main Window size changed when you close a subwindowPopups are broken (reduz is working on this)When you open a dropdown menu it crash (with bad parameter at XCreateWindow)@reduz There are simple changes, if you want to merge, and continue working from this is welcome
There still have a work to do, just making this PR to sync our work