Renamed test_width/height settings to window_width/height #36390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfranke
previously requested changes
Feb 20, 2020
Chaosus
force-pushed
the
rename_sizes
branch
2 times, most recently
from
d539029 to
b9a23f6
Compare
|
I was reading that thread and noticed there was some feedback on the suggestion buried deep within: #16863 (comment). I assume you missed it because the thread is way too long, so I wanted to bring it to your attention just in case. What are your thoughts? |
|
@WARIO-MDMA I missed it but thought about "viewport_width" too |
Chaosus
force-pushed
the
rename_sizes
branch
3 times, most recently
from
29d7a41 to
0171c83
Compare
aaronfranke
approved these changes
Feb 21, 2020
Chaosus
force-pushed
the
rename_sizes
branch
from
0171c83 to
d5fd9a5
Compare
|
Closed. (I need to re-create it since too many changes have been made in master.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the planned renames from:
#16863 (comment)
width/heightis also renamed toviewport_width/height