Make sure we know when deleting an emitting object #35423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Jan 22, 2020
We used a lock signals in the signal_map while emitting, because it was not allowed to disconnect them while being emitted. We used that lock to check if we where deleting an object during signal emission. Now that we allow to disconnect signals while they are being emitted, if an object first disconnects, then gets deleted we can't know that a signal was being emitted during the destructor. This commit adds a new `_emitting` boolean member to Object to be set while emitting and checked in the destructor, while removing the old signal lock which is now unused.
Faless
force-pushed
the
fix/object_emit_free
branch
from
9d9015a to
41f59ec
Compare
akien-mga
approved these changes
Jan 22, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used a lock signals in the signal_map while emitting, because it was not allowed to disconnect them while being emitted.
We used that lock to check if we where deleting an object during signal emission.
Now that we allow to disconnect signals while they are being emitted (#35088), if an object first disconnects, then gets deleted we can't know that a signal was being emitted during the destructor (like in #33290).
This commit adds a new
_emittingboolean member to Object to be set while emitting and checked in the destructor, while removing the old signal lock which is now unused.I hope I got this right 🙄