Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signal for when contents of cell are changed #34475

Closed
wants to merge 2 commits into from
Closed

Add signal for when contents of cell are changed #34475

wants to merge 2 commits into from

Conversation

iatenine
Copy link
Contributor

Enhancement suggested by issue #11855. Creates a new signal for GridMap of "cell_contents_changed"
This signal passes info on the location of the cell updated as a Vector3

Enhancement suggested by issue #11855. Creates a new signal for GridMap of "cell_contents_changed"
This signal passes info on the location of the cell updated as a Vector3
Double spacing seemed to fail automated test
@aaronfranke
Copy link
Member

@iatenine Is this still desired? If so, it needs to be rebased on the latest master branch. While there are no conflicts, rebasing is important so that reviewers can easily test the PR.

@iatenine
Copy link
Contributor Author

iatenine commented Jul 2, 2020

@iatenine Is this still desired? If so, it needs to be rebased on the latest master branch. While there are no conflicts, rebasing is important so that reviewers can easily test the PR.

I don't understand. I only see the single "default" master branch and some version numbers. Is the master branch I'm trying to push to incorrect?

@aaronfranke
Copy link
Member

aaronfranke commented Jul 2, 2020

The branch you have selected is correct, "master" is indeed what you want.

This PR is based on top of the master branch from 6 months ago, so if anyone compiles your branch then they are compiling Godot from 6 months ago. This is why it's often good to periodically rebase. Rebasing is required if there are conflicts, but your PR has none, so rebasing is optional but still nice to do. If you don't want to, you don't have to, it's just something to make maintainers' jobs easier, since then building your branch would build a more recent version of Godot.

It's also simply good to get a reply from you so that we can see you're still active and interested in this feature.

EDIT: Actually, you have two commits in this PR, so this would need a squash for it to be accepted.

@iatenine
Copy link
Contributor Author

iatenine commented Jul 2, 2020

Not sure if I was meant to create a new PR effectively but have rebased and commited here #40044 and will be therefore closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants