Show tooltips normally when the scene tree is paused #29365
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 1, 2019 05:34
This pause mode allows a node to process without affecting children behavior. It can be useful when dealing with uncontrolled content (e.g. root viewport), or existing codebases that rely on the exact tree structure.
Tooltips are managed on the root viewport's NOTIFICATION_INTERNAL_PROCESS. The root viewport has a PAUSE_MODE_INHERIT by default, preventing tooltips from being shown when the scene tree is paused. This sets the root viewport to PAUSE_MODE_SELF_PROCESS, which allows it to show tooltips while paused, without affecting children behavior.
|
Closing because I don't intend to continue working on this PR. |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tooltips are managed on the root viewport's
NOTIFICATION_INTERNAL_PROCESS. The root viewport has aPAUSE_MODE_INHERITby default, preventing tooltips from being shown when the scene tree is paused.This PR adds a new pause mode,
PAUSE_MODE_SELF_PROCESS. that allows a node to process without affecting children behavior, and sets the root viewport to it.Beside this fix, the mode may also be useful in some other cases. For example, when using content provided by third parties, or dealing with existing codebases that rely on the exact tree structure.
Fixes #29362