SCons: Keep exceptions and rtti on Android, iOS and HTML5 tools build #29032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those were disable to keep size small, and on Android avoid the dependency on the STL, but for tools build (editor) this is not really a concern. Note: as of today it's not possible to build tools=yes for those platforms, but this change is one of the necessary steps to enable it. Fixes godotengine#25262.
Yeah, I was able to compile: up until this error occurred: |
|
It actually compiles file for me with |
|
Could it be somehow that this memory issue is caused by me compiling it under WSL? Using 1.38.31 emsdk. This is not an issue for me for now though. |
|
Same for me on Arch Linux using emsdk from https://github.com/emscripten-core/emsdk (master): [user@user godot(x11)]$ scons platform=javascript tools=yes target=release_debug -j 8
scons: Reading SConscript files ...
WebM SIMD optimizations are disabled. Check if your CPU architecture, CPU bits or platform are supported!
Checking for C header file mntent.h... (cached) yes
scons: done reading SConscript files.
scons: Building targets ...
[ 97%] Linking Program ==> bin/godot.javascript.opt.tools.js
[100%] progress_finish(["progress_finish"], [])
[100%] emcc: warning: cannot represent a NaN literal '0x14eadb10' with custom bit pattern in NaN-canonicalizing JS engines (e.g. Firefox and Safari) without erasing bits!
in store float 0xFFFFFFFFE0000000, float* %119, align 4, !tbaa !32 in _ZN22RasterizerStorageGLES318multimesh_allocateE3RIDiN12VisualServer24MultimeshTransformFormatENS1_20MultimeshColorFormatENS1_25MultimeshCustomDataFormatE()
emcc: warning: cannot represent a NaN literal '0x14eadb10' with custom bit pattern in NaN-canonicalizing JS engines (e.g. Firefox and Safari) without erasing bits!
in store float 0xFFFFFFFFE0000000, float* %284, align 4, !tbaa !35 in _ZN22RasterizerStorageGLES218multimesh_allocateE3RIDiN12VisualServer24MultimeshTransformFormatENS1_20MultimeshColorFormatENS1_25MultimeshCustomDataFormatE()
shared:ERROR: Memory is not large enough for static data (12497216) plus the stack (5242880), please increase TOTAL_MEMORY (16777216) to at least 17741120
scons: *** [bin/godot.javascript.opt.tools.js] Error 1
scons: building terminated because of errors.
[user@user godot(x11)]$ |
|
Is it possible to increase the TOTAL_MEMORY with scons? |
|
Should I open a new issue for tools=yes? Only doesn't happen on every computer but it seems to be OS independent. |
|
Cherry-picked for 3.1.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those were disable to keep size small, and on Android avoid the dependency on the STL,
but for tools build (editor) this is not really a concern.
Note: as of today it's not possible to build tools=yes for those platforms, but this
change is one of the necessary steps to enable it.
Fixes #25262.