Add call_recursive method to TreeItem #22834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This could simplify #19936. |
lupoDharkael
changed the title
|
This should be ready to merge but I'd like to have feedback about returning an empty Variant. I did this a while ago. |
akien-mga
reviewed
Jul 2, 2019
akien-mga
reviewed
Jul 2, 2019
lupoDharkael
force-pushed
the
recursive-item
branch
from
19b7381 to
306e64a
Compare
|
I've fixed the typos! (sorry for the delay) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of call_recursive("method", args...) as mentioned here.
What to do with the return? vararg methods require a Variant as a return parameter, should this use it somehow or always return an empty variant?
if it returns an empty variant should the docs say something about it? I added
<return type="Variant">in TreeItem.xml