Fixed segfault when hovering over tree elements and showing tooltips. #10492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubonnek
changed the title
Rubonnek
force-pushed
the
fix-segfault-on-arch-linux
branch
from
3d96eb9 to
0017e21
Compare
|
That fix looks kind of weird indeed, I don't see what would be making |
|
It happens on GCC 7, as another similar issue. I'm starting to think we are being hit by undefined behaviour. That would explain why the code doesn't look as the error condition should happen. If that was the case, this fix wouldn't be addressing the root cause, but I can't be sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10372
I'm still not sure why I have to add this null pointer check in this commit when it was done above. For some reason after adding this check I'm not getting any segmentation fault.